fix: resolve device names to serial numbers and align with SDK 0.13.0 models#218
Merged
Conversation
- device params take serial numbers (14-15 digits), not names - local config: use real model fields (local_version, timestamp, serial, md5) - incidents: use real model fields (incident_id, title, raised_time) - incidents: extract search results from .data, not .incidents - incidents: alerts use alert_id/title/state, remediations is a string - update mock data, CLI table columns, tests, and docs Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add resolve_device_serial() to SCMClient — accepts device name or serial - Serial numbers (14-15 digits) pass through, names resolved via device API - Wire resolution into local config and device operations methods - Update CLI help text to "Device name or serial number" - Align mock data with real SDK 0.13.0 model schemas - Bump version to 1.3.2 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Failed to generate code suggestions for PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--device austin-fw1now works — CLI resolves names to serial numbers viaclient.device.fetch(). Serial numbers (14-15 digits) pass through directly.Test plan
scm operations route-table --device austin-fw1resolves name to serialscm operations route-table --device 007951000123456passes serial directlyscm local list --device austin-fw1works🤖 Generated with Claude Code